Add the list of webparts for the container. #7318
Merged
labkey-klum merged 2 commits intodevelopfrom Jan 12, 2026
Merged
Conversation
…ality for modules per container from the modules table.
labkey-jeckels
approved these changes
Jan 8, 2026
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
This looks fine, but I'm not seeing test coverage. Seems like it should be simple to check the values in an existing automated test that's done some setup.
| .append(" FROM ").append(Portal.getTableInfoPortalWebParts(), "PWP") | ||
| .append(" WHERE PWP.container = " + ExprColumn.STR_TABLE_ALIAS + ".entityId)"); | ||
| ExprColumn webpartColumn = new ExprColumn(this, "WebParts", webpartNamesSQL, JdbcType.VARCHAR); | ||
| webpartColumn.setReadOnly(true); |
Contributor
There was a problem hiding this comment.
Is this needed? I hope ExprColumns are considered read only by default
Contributor
Author
There was a problem hiding this comment.
probably not, it just affect how the column metadata is reported in the table summary view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/685
This adds a
WebPartscolumn to thecore.containerstable to track webparts per container. Additionally we are removing the recently addedActiveFolderscolumn fromcore.modules. The equivalent information was already available asActiveModulesincore.containersbut went largely unnoticed because it was hidden.Both
WebPartsandActiveModulesare not hidden but will not be included in the default view.